-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tcp-proxy: support proxy-protocol tlvs #38131
base: main
Are you sure you want to change the base?
Conversation
Hi @jronak, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jronak could you fix DCO please
also there are quite a lot of other failures - some might be flakes but most look real
some of the format issues can be resolved by applying diffs from CI artefacts here https://github.com/envoyproxy/envoy/actions/runs/12901724937
3f416e8
to
934a2cc
Compare
Signed-off-by: Ronak Jain <[email protected]>
934a2cc
to
44d5fa0
Compare
@phlax fixed fmt and failed tests seems to be flaky. Could you trigger a re-run? |
you can also ... /retest (please check that failures dont look real before retesting) |
/retest |
Additional Description: Adds support for passing Proxy Protocol TLVs in the Proxy Protocol header in tcp_proxy filter
Risk Level: low
Testing: unit test
Docs Changes: tcp-proxy proto config
Release Notes: none