Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcp-proxy: support proxy-protocol tlvs #38131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jronak
Copy link

@jronak jronak commented Jan 22, 2025

Additional Description: Adds support for passing Proxy Protocol TLVs in the Proxy Protocol header in tcp_proxy filter
Risk Level: low
Testing: unit test
Docs Changes: tcp-proxy proto config
Release Notes: none

@jronak jronak requested a review from alyssawilk as a code owner January 22, 2025 05:16
Copy link

Hi @jronak, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #38131 was opened by jronak.

see: more, trace.

Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @wbpcode
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #38131 was opened by jronak.

see: more, trace.

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jronak could you fix DCO please

also there are quite a lot of other failures - some might be flakes but most look real

some of the format issues can be resolved by applying diffs from CI artefacts here https://github.com/envoyproxy/envoy/actions/runs/12901724937

api/envoy/config/core/v3/proxy_protocol.proto Outdated Show resolved Hide resolved
@jronak jronak force-pushed the ronakj/tcp-proxy-tlvs branch from 3f416e8 to 934a2cc Compare January 23, 2025 04:52
@jronak jronak force-pushed the ronakj/tcp-proxy-tlvs branch from 934a2cc to 44d5fa0 Compare January 23, 2025 04:54
@jronak
Copy link
Author

jronak commented Jan 24, 2025

@phlax fixed fmt and failed tests seems to be flaky. Could you trigger a re-run?

@phlax
Copy link
Member

phlax commented Jan 24, 2025

you can also ...

/retest

(please check that failures dont look real before retesting)

@jronak
Copy link
Author

jronak commented Jan 24, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants