fix(credential_injector/oauth2): send scopes when specified #38130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code inadvertently shadows the existing body declaration such that when scopes are specified, they are not actually sent to the authorization server. Signed-off-by: Adam Eijdenberg <[email protected]>
|
Hi @ae-govau, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
/retest |
bazmurphy
pushed a commit
to bazmurphy/envoy
that referenced
this pull request
Jan 29, 2025
…xy#38130) Commit Message: Current code inadvertently shadows the existing body declaration such that when scopes are specified, they are not actually sent to the authorization server. Additional Description: Risk Level: Testing: Added test, verified it errors on current code and is resolved after this fix. Docs Changes: None, this now matches the existing documentation. Release Notes: Added CHANGELOG entry. Platform Specific Features: Signed-off-by: Adam Eijdenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Current code inadvertently shadows the existing body declaration such that when scopes are specified, they are not actually sent to the authorization server.
Additional Description:
Risk Level:
Testing:
Added test, verified it errors on current code and is resolved after this fix.
Docs Changes:
None, this now matches the existing documentation.
Release Notes:
Added CHANGELOG entry.
Platform Specific Features: