Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ext_proc MxN API #37774

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yanjunxiang-google
Copy link
Contributor

Enable ext_proc MxN API

Signed-off-by: Yanjun Xiang <[email protected]>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #37774 was opened by yanjunxiang-google.

see: more, trace.

Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @wbpcode
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #37774 was opened by yanjunxiang-google.

see: more, trace.

Signed-off-by: Yanjun Xiang <[email protected]>
@yanjunxiang-google yanjunxiang-google marked this pull request as ready for review January 3, 2025 21:01
@yanjunxiang-google
Copy link
Contributor Author

/assign @yanavlasov @tyxia

@yanjunxiang-google
Copy link
Contributor Author

/assign @jmarantz

Signed-off-by: Yanjun Xiang <[email protected]>
Signed-off-by: Yanjun Xiang <[email protected]>
@jmarantz
Copy link
Contributor

jmarantz commented Jan 5, 2025

I'll defer to Yan for this as I feel there might be a good process for evaluating this.

@tyxia
Copy link
Member

tyxia commented Jan 6, 2025

@yanjunxiang-google AFAIK, we have not done the load test for this feature? If we want to expose this API now, do you want to add a warning comment, followed by a TODO action to load test it.

@yanavlasov
Copy link
Contributor

@yanjunxiang-google please resolve merge conflict.

/wait

Signed-off-by: Yanjun Xiang <[email protected]>
@yanavlasov
Copy link
Contributor

@yanjunxiang-google Seems like there is a bit of whack-a-mole with the current.yaml

/wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants