-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main #114
Main #114
Conversation
… English and Korean versions
Reviewer's Guide by SourceryThis pull request makes minor changes to the conclusion section headers in two markdown files (English and Korean versions). The changes involve renaming the section from "Closing Remarks" to "Conclusion" in English, and from "마무리 발언" to "결론" in Korean. No sequence diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @entelecheia - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -392,6 +392,6 @@ for temp in temperatures: | |||
|
|||
--- | |||
|
|||
## 9. Closing Remarks | |||
## Conclusion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Consider enhancing the conclusion with a brief summary of key points
To make the conclusion more valuable, consider adding a concise recap of the main concepts covered in this session. This will reinforce the learning and provide a quick reference for readers.
## Conclusion | |
## Conclusion | |
In this session, we explored: | |
- The importance of sampling methods in LLM APIs | |
- Key parameters like temperature and top-p | |
- Strategies for balancing creativity and coherence | |
- Techniques for tailoring output to specific formats | |
Understanding these concepts is crucial for leveraging LLMs effectively. |
Summary by Sourcery
Update section titles in both English and Korean documentation for week 6, session 2, to use 'Conclusion' instead of 'Closing Remarks'.
Documentation: