Expand parent directories of opened projects #11947
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
added
CI: No changelog needed
somebody1234
requested review from
PabloBuchu,
indiv0 and
MrFlashAccount
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
somebody1234
commented
Dec 30, 2024
PabloBuchu
approved these changes
Jan 2, 2025
somebody1234
requested review from
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
app/gui/src/dashboard/components/dashboard/DirectoryNameColumn.tsx
Outdated
Show resolved
Hide resolved
app/gui/src/dashboard/components/dashboard/column/PathColumn.tsx
Outdated
Show resolved
Hide resolved
app/gui/src/dashboard/layouts/Drive/Categories/categoriesHooks.tsx
Outdated
Show resolved
Hide resolved
MrFlashAccount
requested changes
Jan 6, 2025
|
🚫 Also, We need integration tests for this feature |
| @@ -1,83 +0,0 @@ | |||
| import { DirectoryId } from '#/services/Backend' | |||
There was a problem hiding this comment.
Why did we remove the tests?
There was a problem hiding this comment.
behavior has been changed so these tests are no longer relevant
we can write a new test in the same style if that works?
There was a problem hiding this comment.
Yes for sure. Unrelevant tests can be removed, but we need to add new ones if we add a new behavior. Coverage shouldn't decrease
…f in a `useEffect`
@MrFlashAccount wdym by this btw? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
None
Testing Instructions
enso/to local favorites and open project)Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.