Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when trying to resolve to display names with duplicates. #34

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

daniel-k
Copy link
Member

@daniel-k daniel-k commented Dec 7, 2023

Follow-up from #32 (comment)

Copy link

github-actions bot commented Dec 7, 2023

Coverage results

Update on 2024-10-02 12:41:47.470786027 +0000

This is the coverage report for commit 85c30e8

Name                                                                                Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------------------------------
.tox/py/lib/python3.12/site-packages/enlyze/__init__.py                                 4      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/base.py                        70      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/production_runs/client.py      20      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/production_runs/models.py      52      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/timeseries/client.py           19      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/timeseries/models.py           44      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/auth.py                                    13      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/client.py                                 108      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/constants.py                                8      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/errors.py                                   4      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/iterable_tools.py                           7      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/models.py                                 117      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/schema.py                                  26      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/validators.py                              38      0   100%
-----------------------------------------------------------------------------------------------------------------
TOTAL                                                                                 530      0   100%

4 empty files skipped.

Copy link
Member

@denizs denizs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should at least warn about the fact that there are variables with duplicate display names.

@daniel-k daniel-k changed the title Add note to TimeseriesData.to_dataframe() about duplicate display names. Raise error when trying to resolve to display names with duplicates. Oct 1, 2024
@daniel-k daniel-k requested a review from denizs October 1, 2024 09:09
@daniel-k daniel-k merged commit 3d2d564 into master Oct 2, 2024
9 checks passed
@daniel-k daniel-k deleted the fix/docs-timeseries-to-df-warning-display-names branch October 2, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants