-
Notifications
You must be signed in to change notification settings - Fork 42
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
hw dev v2: Make the python3 toolchain hermetic (#853)
This change introduces bazel's hermetic toolchain feature to rules_python. Registering rules_python with a toolchain required stage_4() to be created to properly initialize the WORKSPACE file. Next Steps: * Merge this pull request. * Modify the enfabrica-bot enkit version update pull request to also include the stage_4() changes from this pull request. If the enfabrica-bot pull request is merged without stage_4() in the WORKSPACE file, then toolchain registration of rules_python will fail. * Merge the modified enfabrica-bot pull request. * Do not merge hw dev v2: Integrate the python3 hermetic toolchain internal#14744 and close it instead. JIRA: INFRA-4372
- Loading branch information
1 parent
4862522
commit 559ad63
Showing
8 changed files
with
323 additions
and
290 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
"""Stage 4 configuration for enkit WORKSPACE. | ||
See README.md for more information. | ||
""" | ||
|
||
load("@enkit_pip_deps//:requirements.bzl", python_deps = "install_deps") | ||
|
||
def stage_4(): | ||
"""Stage 4 initialization for WORKSPACE. | ||
This step includes any initialization which can't take place in stage 3 for | ||
various reasons, including: | ||
* A transitive load statement that references a repository that doesn't | ||
exist until stage 3 completes | ||
""" | ||
|
||
python_deps() |
548 changes: 274 additions & 274 deletions
548
bazel/utils/testdata/remote/with-all-inputs.files_to_copy.expected
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters