Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more flexible PythonEngine configuration variables #42

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tomac
Copy link

@tomac tomac commented Oct 20, 2020

Issues

In order to be more flexible with the PythonEngine configuration options, it would be better to let users to define some internal keys and not being so endgame-centric :) Adding the option to change the process type, as well as the process subtype and create/termination event subtypes would be great.

Details

Describe details about your requested changes

Copy link
Contributor

@rw-access rw-access left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good!

mind adding a unit test? might feel like overkill, but could help to make sure we don't add regressions in the future

@rw-access
Copy link
Contributor

here's an example test that's similar:
https://github.com/endgameinc/eql/blob/master/tests/test_python_engine.py#L433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants