Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faucet #310

Merged
merged 11 commits into from
May 25, 2023
Merged

Faucet #310

merged 11 commits into from
May 25, 2023

Conversation

pifragile
Copy link
Contributor

@pifragile pifragile requested review from clangenb and brenzi May 10, 2023 09:00
scheduler/src/lib.rs Outdated Show resolved Hide resolved
faucet/src/tests.rs Outdated Show resolved Hide resolved
faucet/src/tests.rs Outdated Show resolved Hide resolved
faucet/src/lib.rs Outdated Show resolved Hide resolved
faucet/src/tests.rs Outdated Show resolved Hide resolved
faucet/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@brenzi brenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very lean and clean, was a very pleasant review, thx

I do like logs for debugging, so I request that you print a log for every Event that you spawn. We do that in other pallets too and it really helps.

@brenzi brenzi merged commit e26befa into master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement sybil-resistant faucet for KSM new pallet encointer_reputation_commitments
2 participants