-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(supervisors): fix occasional assertion failures and hangs #2431
Open
vvanglro
wants to merge
21
commits into
encode:master
Choose a base branch
from
vvanglro:fix/test_hang
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
b1bf81c
test(supervisors): ensure cleanup in test_multiprocess by using 'fina…
vvanglro b4d8b09
test(supervisor): add timeout to multiprocess test subprocess
vvanglro a65c61a
try to solve
vvanglro d832a5a
try to solve
vvanglro cd7dcc9
Merge branch 'master' into fix/test_hang
vvanglro 27c6968
feat: add retry for unstable tests
vvanglro f0d496e
test(supervisor): remove retry, ensure process close.
vvanglro 239a3cf
Merge branch 'master' into fix/test_hang
vvanglro ffe43cb
test case
vvanglro 41583fd
Merge branch 'master' into fix/test_hang
vvanglro 5b97b39
Merge branch 'master' into fix/test_hang
vvanglro d737e28
Merge branch 'master' into fix/test_hang
vvanglro b8f2769
Merge branch 'master' into fix/test_hang
Kludex 0b1b372
test(supervisors): improve test_multiprocess reliability
vvanglro bd08e0e
test(supervisors): improve test_multiprocess reliability
vvanglro 0956647
Merge branch 'master' into fix/test_hang
vvanglro f95cd0f
test(supervisors): improve test_multiprocess reliability
vvanglro 49c40db
Merge branch 'master' into fix/test_hang
vvanglro 7c48f04
Release gil to let the supervisor thread switch execution
vvanglro 418dc84
format
vvanglro b8a0686
Merge branch 'master' into fix/test_hang
vvanglro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need the timeout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this was added earlier when I was investigating why it was hanging. No need for it now, I'll remove it later