-
-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce sync API. #735
Conversation
Figure we can probably mark this as ready for review here. We probably still want to do a bit of work on wrapping exception classes, but that could be a follow-on PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I've looked at this for some time and played with it in the console, looks good! 🥇 Just a few minor comments.
Though I can't wait for us unasync'ing all this duplicated code in the client, maybe someday? 🤣
I think that one is a solid maybe, and could go either way. 😃 The only non-trivial chunk of stuff that unasync would deduplicate is https://github.com/encode/httpx/blob/sync/httpx/client.py#L1040-L1216 which is a fairly modest amount for us to maintain, so I could equally well see an |
In any case I think we'll start with the dispatch layer, if/when we switch away from urllib3. :-) |
Closes #572
Client
.URLLib3Dispatcher
.