refactor: remove unused code from deserializer #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. Could you update the commit message to be a conventional commit? Maybe: |
hw0lff
changed the title
Did you mean the title of the PR? |
|
No, with the commit itself. Could you squash and re-word it, then force-push it back to this branch. |
Signed-off-by: Hendrik Wolff <[email protected]>
Done. |
rjzak
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TagAccesstype from theciborium::demodule seems to be unused.Only the
crate::tag::TagAccessis used.So I removed it and replaced the qualified path
crate::tag::TagAccesswith auseimport.Additionally a header pull followed by a push was also removed, since it