Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Added key-pair + certificate generation. #15

Closed
wants to merge 1 commit into from

Conversation

MikeCamel
Copy link

Fixes #14 .

@MikeCamel
Copy link
Author

Note - the clippy failure is not in my code, but in previously-merged code.

@ueno
Copy link
Contributor

ueno commented Oct 1, 2020

Yes, the failure should be fixed with #16.

Copy link
Contributor

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused with this, so please correct if I'm wrong. The generated keypair is needed to establish a TLS connection for a tenant to send a Wasm workload to a keep, right? If so shouldn't it be bound to some tenant-supplied identity (e.g., a secret injected in the attestation phase)?

@npmccallum
Copy link
Contributor

I'm a bit confused with this, so please correct if I'm wrong. The generated keypair is needed to establish a TLS connection for a tenant to send a Wasm workload to a keep, right? If so shouldn't it be bound to some tenant-supplied identity (e.g., a secret injected in the attestation phase)?

Pre-attestation: yes
Post-attestation: no

In the post-attestation case, the public key is included in an attestation report and embedded into the x509 cert. The client validates the certificate signature (to ensure no modifications) and then evaluates the attestation report (to ensure the private key is in a keep).

@MikeCamel
Copy link
Author

Out of date

@MikeCamel MikeCamel closed this Jan 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add key-pair and certificate generation
5 participants