Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: bump rules_nodejs and migrate to rules_js #1388

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

linzhiq
Copy link

@linzhiq linzhiq commented May 27, 2024

Bazel's Node.js dependency comes from rules_nodejs. Previously, bazel/deps.bzl was using rules_nodejs 5.8.0, released in 2022 and only supported Node.js toolchains up to 18.12.1.

This PR bumps rules_nodejs to latest 6.1.1. It also replaces build_bazel_rules_nodejs with rules_js, since npm_install that bazel/emscripten_deps.bzl used was deprecated. The README of rules_nodejs now recommends migrating to rules_js for everything other than the Node.js toolchain: (bazel-contrib/rules_nodejs@371e8ca)

Impetus

Our repo builds with Bazel and uses Emscripten and Node.js. Tried to upgrade Node.js 18 to Node.js 20 and saw that emsdk didn't support rules_nodejs 6+ in the same workspace.

@walkingeyerobot
Copy link
Collaborator

I'm generally in favor of upgrading here but this causes the bazel CI tests to fail.

@mmorel-35
Copy link

mmorel-35 commented Jun 3, 2024

@keith,
Can you provide help on that ?
It will help create a true bzlmod compatibility to emsdk which is requested in bcr issues

@keith
Copy link

keith commented Jun 3, 2024

I think we probably need to fix the CI here first

@allsey87
Copy link
Contributor

allsey87 commented Jun 14, 2024

@walkingeyerobot I would also like to upgrade rules_nodejs and nodejs since embuilder is complaining about the current version used in the Bazel workspace and this might be the source of the errors that I am seeing in #1405

embuilder: warning: node version appears too old (seeing "v16.6.2", expected "v16.20.0") [-Wversion-check]

Should I take over this PR or perhaps open a new one? I don't think I can push commits here unless I am a "maintainer" to this repository, right?

@walkingeyerobot
Copy link
Collaborator

You're welcome to open a new one; I am unsure how to transfer ownership of a PR, so new one seems easiest.

@eric-higgins-ai
Copy link

eric-higgins-ai commented Aug 18, 2024

opened a new PR to fix CI #1436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants