Fix support fish shell in emsdk.py #1239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Jun 23, 2023
| @@ -114,15 +114,16 @@ def exit_with_error(msg): | |||
| UNIX = (MACOS or LINUX) | |||
|
|
|||
|
|
|||
| # Pick which shell of 4 shells to use | |||
| # Pick which shell of 5 shells to use | |||
There was a problem hiding this comment.
Maybe just # Pick which shell to use?
There was a problem hiding this comment.
I wonder if we should add some basic CI testing for other shells?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shell: Fish
OS: macOS
fish: Unknown command: unset