Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a battery sensor to battery powered devices #234

Merged
merged 48 commits into from
Aug 18, 2023
Merged

Add a battery sensor to battery powered devices #234

merged 48 commits into from
Aug 18, 2023

Conversation

stefanbode
Copy link
Contributor

This should work without modifications in HA and enable the battery magic in HA.

Tasmota Command:
batterypercentage 45 to set something. restart 1 required if not enabled before

batterypercentage 101 to disable battery., restart 1 required

@stefanbode
Added battery & deepsleep
024f68d
@stefanbode
Update const.py
e7df50b
@stefanbode
Update device_status.py
fbc932c
@stefanbode
Update status_sensor.py
4084386
@stefanbode
Update device_status.py
00fa1eb
@stefanbode
Update utils.py
8e64232
@stefanbode
Update discovery.py
c9b69c5
@stefanbode
Create deepsleep.py
ca6a994
@stefanbode
Update const.py
5c572a2
@stefanbode
New class for deepsleep
c210564
@stefanbode
Update device_status.py
6e2e884
@stefanbode
Update discovery.py
27eda72
@stefanbode
Update discovery.py
eeb22b9
@stefanbode
Update discovery.py
63bcf7f
@stefanbode
Update status_sensor.py
f7d8506
@stefanbode
Update const.py
a9a18fd
@stefanbode
Update status_sensor.py
f85fd67
@stefanbode
Update status_sensor.py
63597b4
@stefanbode
Update status_sensor.py
a07d628
@stefanbode
Update status_sensor.py
792dbcf
@stefanbode
Update status_sensor.py
03caf89
@stefanbode
Update status_sensor.py
0c796db
@stefanbode
Update status_sensor.py
a752d77
@stefanbode
Update status_sensor.py
572c6ed
@stefanbode
Update sensor.py
e0d6d56
@stefanbode
Update sensor.py
e093a68
@stefanbode
Update const.py
dbd5757
@stefanbode
Update status_sensor.py
acb302e
@stefanbode
Update utils.py
eae0286
@stefanbode
Delete deepsleep.py
5eb9541
@emontnemery emontnemery changed the title Battery enabled Add a battery sensor to battery powered devices Aug 18, 2023
emontnemery
emontnemery requested changes Aug 18, 2023
View reviewed changes
Copy link
Owner

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

I added some suggested changes though:

  • Let's remove the deep sleep related changes from this PR.
  • I also think we should better separate the battery percentage sensor from a "normal" battery sensor, hence a separate constant for that

hatasmota/const.py Outdated Show resolved Hide resolved
hatasmota/const.py Outdated Show resolved Hide resolved
hatasmota/const.py Outdated Show resolved Hide resolved
hatasmota/device_status.py Outdated Show resolved Hide resolved
hatasmota/discovery.py Outdated Show resolved Hide resolved
hatasmota/status_sensor.py Show resolved Hide resolved
hatasmota/status_sensor.py Outdated Show resolved Hide resolved
hatasmota/status_sensor.py Outdated Show resolved Hide resolved
hatasmota/status_sensor.py Outdated Show resolved Hide resolved
hatasmota/status_sensor.py Outdated Show resolved Hide resolved
stefanbode and others added 13 commits August 18, 2023 14:04
@stefanbode @emontnemery
Update hatasmota/discovery.py
52a342a 
Co-authored-by: Erik Montnemery <[email protected]>
@stefanbode @emontnemery
Update hatasmota/status_sensor.py
8114bea 
Co-authored-by: Erik Montnemery <[email protected]>
@stefanbode @emontnemery
Update hatasmota/status_sensor.py
cb53db8 
Co-authored-by: Erik Montnemery <[email protected]>
@stefanbode @emontnemery
Update hatasmota/const.py
9ed26a0 
Co-authored-by: Erik Montnemery <[email protected]>
@stefanbode @emontnemery
Update hatasmota/const.py
a207503 
Co-authored-by: Erik Montnemery <[email protected]>
@stefanbode @emontnemery
Update hatasmota/device_status.py
591d39f 
Co-authored-by: Erik Montnemery <[email protected]>
@stefanbode @emontnemery
Update hatasmota/const.py
f251421 
Co-authored-by: Erik Montnemery <[email protected]>
@stefanbode @emontnemery
Update hatasmota/status_sensor.py
93fb0a6 
Co-authored-by: Erik Montnemery <[email protected]>
@stefanbode @emontnemery
Update hatasmota/status_sensor.py
3f41d3f 
Co-authored-by: Erik Montnemery <[email protected]>
@stefanbode @emontnemery
Update hatasmota/discovery.py
1beb93c 
Co-authored-by: Erik Montnemery <[email protected]>
@stefanbode @emontnemery
Update hatasmota/discovery.py
2d6db30 
Co-authored-by: Erik Montnemery <[email protected]>
@stefanbode @emontnemery
Update hatasmota/status_sensor.py
2243978 
Co-authored-by: Erik Montnemery <[email protected]>
@stefanbode
Update discovery.py
1b18e8d
@stefanbode
Copy link
Contributor Author

All changes accepted

emontnemery
emontnemery reviewed Aug 18, 2023
View reviewed changes
hatasmota/discovery.py Outdated Show resolved Hide resolved
emontnemery
emontnemery approved these changes Aug 18, 2023
View reviewed changes
Copy link
Owner

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @stefanbode 👍

@emontnemery emontnemery merged commit 1d6f160 into emontnemery:master Aug 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emontnemery emontnemery emontnemery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanbode @emontnemery