Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: reader threads debug option #778

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Oct 21, 2023

RE: #770

@emmercm emmercm self-assigned this Oct 21, 2023
@emmercm emmercm marked this pull request as draft October 21, 2023 23:43
@github-actions
Copy link

github-actions bot commented Oct 21, 2023

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/reader-threads-option" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm marked this pull request as ready for review October 23, 2023 01:52
@emmercm emmercm enabled auto-merge (squash) October 23, 2023 01:52
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #778 (5e5f4cc) into main (d8ef643) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #778   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files          84       84           
  Lines        5131     5132    +1     
  Branches     1163     1164    +1     
=======================================
+ Hits         4805     4806    +1     
  Misses        309      309           
  Partials       17       17           
Files Coverage Δ
src/constants.ts 93.10% <100.00%> (-0.65%) ⬇️
src/modules/argumentsParser.ts 98.12% <100.00%> (+0.01%) ⬆️
src/modules/datScanner.ts 87.26% <100.00%> (ø)
src/modules/patchScanner.ts 94.28% <ø> (ø)
src/modules/romHeaderProcessor.ts 100.00% <ø> (ø)
src/modules/romScanner.ts 100.00% <ø> (ø)
src/types/options.ts 99.02% <100.00%> (+<0.01%) ⬆️

@emmercm emmercm merged commit b1e9ee1 into main Oct 23, 2023
50 checks passed
@emmercm emmercm deleted the emmercm/reader-threads-option branch October 23, 2023 02:12
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant