Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wgpu: Bump to wgpu 23.0.0 and wasm-bindgen to 0.2.95 #5330

Merged
merged 6 commits into from
Oct 30, 2024
Merged

wgpu: Bump to wgpu 23.0.0 and wasm-bindgen to 0.2.95 #5330

merged 6 commits into from
Oct 30, 2024

Conversation

torokati44
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5330-wgpu-23
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@torokati44 torokati44 mentioned this pull request Oct 30, 2024
Open
@ArthurBrussee
Copy link
Contributor

Hah race condition, did the same. For the cargo deny errors, you can get some inspiration of my branch

https://github.com/ArthurBrussee/egui/tree/wgpu-upgrade

Wumpf
Wumpf approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@Wumpf Wumpf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can have a look at the dependency bonanza later

There's also changes I want to make to web backend I want to make - there's now utilities in wgpu that make WebGPU detection a lot saner

crates/egui_demo_app/src/apps/custom3d_wgpu.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf added egui-wgpu dependencies Pull requests that update a dependency file labels Oct 30, 2024
@Wumpf Wumpf merged commit 67c82ed into emilk:master Oct 30, 2024
48 checks passed
@torokati44
Copy link
Contributor Author

Whoo, thanks a lot for sorting out the dependency situation, and finishing this up so quickly!

hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@torokati44 @Wumpf @hacknus
wgpu: Bump to wgpu 23.0.0 and wasm-bindgen to 0.2.95 (emilk#5330)
17eecaa 
Co-authored-by: Andreas Reich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file egui-wgpu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torokati44 @ArthurBrussee @Wumpf