Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egui-winit: Remove implicit accesskit_winit feature #5316

Merged

Conversation

waywardmonkeys
Copy link
Contributor

This is controlled by the accesskit feature and nothing needs the implicit accesskit_winit feature, so use dep: syntax to prevent it from being created.

  • I have followed the instructions in the PR template

This is controlled by the `accesskit` feature and nothing needs
the implicit `accesskit_winit` feature, so use `dep:` syntax
to prevent it from being created.
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops!

@emilk emilk added the egui-winit porblems related to winit label Oct 29, 2024
@emilk emilk changed the title egui-winit: Remove implicit accesskit_winit feature egui-winit: Remove implicit accesskit_winit feature Oct 29, 2024
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5316-remove-implicit-feature-for-accesskit-winit
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@emilk emilk merged commit fba2dc8 into emilk:master Oct 29, 2024
24 of 25 checks passed
@waywardmonkeys waywardmonkeys deleted the remove-implicit-feature-for-accesskit-winit branch October 29, 2024 16:09
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
This is controlled by the `accesskit` feature and nothing needs the
implicit `accesskit_winit` feature, so use `dep:` syntax to prevent it
from being created.

* [x] I have followed the instructions in the PR template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
egui-winit porblems related to winit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants