Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Sides did not apply the layout position correctly. #5232

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix: Sides did not apply the layout position correctly. #5232

merged 2 commits into from
Oct 23, 2024

Conversation

zhatuokun
Copy link
Contributor

Run this code

        CentralPanel::default().show(ctx, |ui| {
            Sides::new().show(
                ui,
                |ui| {
                    ui.label("1");
                },
                |ui| {
                    ui.label("2");
                },
            );
            Sides::new().show(
                ui,
                |ui| {
                    ui.label("11");
                },
                |ui| {
                    ui.label("22");
                },
            );
            Sides::new().show(
                ui,
                |ui| {
                    ui.label("111");
                },
                |ui| {
                    ui.label("222");
                },
            );
        });

Before

before

After

after

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Preview available at https://egui-pr-preview.github.io/pr/5232-fix-sides-layout-position
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

emilk
emilk approved these changes Oct 23, 2024
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call

@emilk emilk added bug Something is broken egui labels Oct 23, 2024
@emilk emilk merged commit 6add64e into emilk:master Oct 23, 2024
24 of 25 checks passed
emilk added a commit that referenced this pull request Oct 23, 2024
@emilk
Revert "Fix: Sides did not apply the layout position correctly. (#5232
31e7ecc 
)"

This reverts commit 6add64e.
@emilk emilk mentioned this pull request Oct 23, 2024
Merged
emilk added a commit that referenced this pull request Oct 23, 2024
@emilk
Revert "Fix: Sides did not apply the layout position correctly." (#…
68d312d 
…5300)

Reverts #5232

I should have tested it first. `cursor` can contain infinites. There is
a better fix to be found @zhatuokun
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@zhatuokun @hacknus
Fix: Sides did not apply the layout position correctly. (emilk#5232)
57d71a2 
<!--
Please read the "Making a PR" section of
[`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md)
before opening a Pull Request!

* Keep your PR:s small and focused.
* The PR title is what ends up in the changelog, so make it descriptive!
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to
`egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for
maintainers to test and add commits to your PR.
* Remember to run `cargo fmt` and `cargo clippy`.
* Open the PR as a draft until you have self-reviewed it and run
`./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.

Please be patient! I will review your PR, but my time is limited!
-->

Run this code

```rs
        CentralPanel::default().show(ctx, |ui| {
            Sides::new().show(
                ui,
                |ui| {
                    ui.label("1");
                },
                |ui| {
                    ui.label("2");
                },
            );
            Sides::new().show(
                ui,
                |ui| {
                    ui.label("11");
                },
                |ui| {
                    ui.label("22");
                },
            );
            Sides::new().show(
                ui,
                |ui| {
                    ui.label("111");
                },
                |ui| {
                    ui.label("222");
                },
            );
        });
```

Before


![before](https://github.com/user-attachments/assets/2678f937-859e-422a-9171-5f2a63166c8f)

After


![after](https://github.com/user-attachments/assets/879892f1-a69d-4540-8e56-8b2448e939ed)
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@emilk @hacknus
Revert "Fix: Sides did not apply the layout position correctly." (e…
9b2e366 
…milk#5300)

Reverts emilk#5232

I should have tested it first. `cursor` can contain infinites. There is
a better fix to be found @zhatuokun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
bug Something is broken egui exclude from changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhatuokun @emilk