Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain Changelogs in Git annotated tags #262

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

dmikurube
Copy link
Member

Maintaining ChangeLog is hard, and sometimes conflicts with release operations with the GitHub review process.

I re-tagged all v0.* tags in this repository to be Git-annotated with the contents of the existing ChangeLog reformatted in the Keep a Changelog format: https://keepachangelog.com/en/1.1.0/

See: https://github.com/embulk/embulk-input-jdbc/tags

Then, this pull request is to override ChangeLog as a reference to Git annotated tags.

@dmikurube dmikurube requested a review from a team as a code owner August 13, 2024 07:14
Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@dmikurube
Copy link
Member Author

@hito4t Letting you know just in case. I'll merge this tomorrow unless you have any concern.

@dmikurube
Copy link
Member Author

Merging!

@dmikurube dmikurube merged commit 4d0d07b into master Aug 14, 2024
12 checks passed
@dmikurube dmikurube deleted the changelog-in-annotated-tags branch August 14, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants