Fix non-existing executables. #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size: Print a warning when an executable does not exist.
Warning: cubic executable not found.
Warning: md5sum executable not found.
Benchmark size
--------- ----
aha-mont64 27.47
crc32 92.41
cubic 0.00
speed: Fail gracefully with a nice error message instead of a python
trace.
Warning: cubic executable not found.
Warning: md5sum executable not found.
Benchmark Speed
--------- -----
...
ud 10.59
wikisort 21.80
ERROR: Failed to compute speed benchmarks
Signed-off-by: Daniel Schultz <[email protected]>
|
Hi @dnltz Sorry for the slow response. I like this patch. However I think it will still compute the overall Embench score from the successful benchmarks. It should be modified to not compute the overall score unless all the benchmarks succeed. Would you be able to add this. Then I can merge it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
size: Print a warning when an executable does not exist.
speed: Fail gracefully with a nice error message instead of a python
trace.
Signed-off-by: Daniel Schultz [email protected]