Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug printfs from benchmarks #152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mtdudek
Copy link

@mtdudek mtdudek commented Nov 12, 2021

This commit removes printfs from md5sum test, as they can influence test results.
Signed-off-by: Maciej Dudek [email protected]

@jeremybennett
Copy link
Collaborator

@mtdudek Thanks for picking this up. There should be no external library calls in the benchmark.

I'd rather just remove this code. The danger with #define is that users will define them on the command line and we'll get invalid results. Are you happy to make this change?

Added @PaoloS02 as a second reviewer.

@mtdudek
Copy link
Author

mtdudek commented Nov 15, 2021

I've removed printfs from benchmarks' bodies.

@mtdudek mtdudek changed the title Remove debug printfs from md5sum Remove debug printfs from benchmarks Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants