Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add results of voyage-3 and voyage-3-lite #35

Merged
merged 9 commits into from
Oct 6, 2024

Conversation

Liuhong99
Copy link
Contributor

  • Added results of voyage-3 and voyage-3-lite to results
  • Added voyage-3 and voyage-3-lite to results.py
  • Added voyage-3 and voyage-3-lite result paths to paths.json

Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Seems like these models are not in the mteb models folder. We would love to have them added to ensure reproducibility

@KennethEnevoldsen KennethEnevoldsen enabled auto-merge (squash) September 28, 2024 16:34
@KennethEnevoldsen
Copy link
Contributor

@Liuhong99 seems like tests fail due to missing model_meta.json file

@Liuhong99
Copy link
Contributor Author

Thanks for the reminder! @KennethEnevoldsen Where shall we put into the revision field of the model_meta.json file? Is it supposed to be the same as the folder name where we save the result json files? What if the revision name is no_revision_available?

@orionw
Copy link
Contributor

orionw commented Oct 1, 2024

I think this is blocking the leaderboard GitHub now. We should add a test to block the leaderboard from allowing it to pass if the results aren’t present.

@Liuhong99 it should be able to go in the no_revision_available folder, I think. Let me know if you’re able to do this, otherwise I will revert the leaderboard commit until we’re ready.

auto-merge was automatically disabled October 1, 2024 18:38

Head branch was pushed to by a user without write access

@Liuhong99
Copy link
Contributor Author

@orionw Added model_meta.json to the no_revision_available folder. Please let me know what other action I should take. Thanks so much!

@orionw
Copy link
Contributor

orionw commented Oct 1, 2024

Thanks! It's close, the names have to match in the folder name the model_meta.json -- see the test error:

E AssertionError: assert PosixPath('/home/runner/work/results/results/results/voyage-3/no_revision_available') == PosixPath('/home/runner/work/results/results/results/voyageai__voyage-3/no_revision_available')

e.g. the voyageai__voyage-3 vs voyage-3

@Liuhong99
Copy link
Contributor Author

Got it; thanks! Fixed the names.

@orionw
Copy link
Contributor

orionw commented Oct 1, 2024

Thanks @Liuhong99! I don't think the remaining errors are yours, pinging @KennethEnevoldsen if he knows. Seems like some issue with the test runner tbh.

@Liuhong99
Copy link
Contributor Author

@KennethEnevoldsen @orionw After fixing the results format, all checks have passed! Thanks guys!

@@ -0,0 +1 @@
{"name": "voyageai__voyage-3-lite", "revision": "no_revision_available", "release_date": "2024-09-22", "languages": null, "n_parameters": null, "memory_usage": null, "max_tokens": 32000, "embed_dim": 512, "license": null, "open_source": false, "similarity_fn_name": null, "framework": [], "loader": "VoyageWrapper"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it use the MTEB voyage wrapper?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(if so I believe we can merge this in - otherwise we can simply leave it empty)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes confirmed all results come from mteb/models/voyage_models.py.

@KennethEnevoldsen KennethEnevoldsen merged commit e7d51d9 into embeddings-benchmark:main Oct 6, 2024
2 checks passed
orionw added a commit to embeddings-benchmark/leaderboard that referenced this pull request Oct 6, 2024
They were removed until the results were added, [now done](embeddings-benchmark/results#35 (comment))
orionw added a commit to embeddings-benchmark/leaderboard that referenced this pull request Oct 8, 2024
* Re-Add Voyage 3 Models

They were removed until the results were added, [now done](embeddings-benchmark/results#35 (comment))

* Spacing fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants