-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-add GritLM-7B-noinstruct #28
Conversation
We've discussed why it was removed #25 (comment) |
I see; I guess we should add it back in but maybe make sure model_meta is different then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the name fix, I think we can add it in. Tests also still fail
results/GritLM__GritLM-7B-noinstruct/13f00a0e36500c80ce12870ea513846a066004af/model_meta.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Kenneth Enevoldsen <[email protected]>
Test is failing; I think it is because it is looking for |
I think that you can change fixture for test, because no_revision_available this is old result and GritLM versions are already presented here
|
Makes sense, thanks! It seems like there is some difference in FollowIR results e.g. https://github.com/embeddings-benchmark/results/blob/standardizegrit/results/GritLM__GritLM-7B/no_revision_available/Robust04InstructionRetrieval.json vs https://github.com/embeddings-benchmark/results/blob/standardizegrit/results/GritLM__GritLM-7B/13f00a0e36500c80ce12870ea513846a066004af/Robust04InstructionRetrieval.json & same for others. I think it is because I reran all MTEB tasks including them with GritLM. |
It could be, perhaps I did something wrong to the formatting. As long as the instructions were correctly passed in and it looks like it would be unless there was a prompt conflict then it should be fine. I'm going to take a closer look at the instruction setup next week so I'm good with keeping the newer results! |
It seems like the
GritLM__GritLM-7B-noinstruct
results present here https://github.com/embeddings-benchmark/results/tree/319e81d64298f3bdc5f09c8b6ff91f5015b3664c/results/GritLM-7B-noinstruct are no longer present here https://github.com/embeddings-benchmark/results/tree/9a79f7e07542ad2f5cb47490fa1e5ac2ba57d7a8/results; probably they were accidentally deleted so this PR adds them back in & also merges the separate GritLM folders; Currently the regular GritLM-7B is missing from the RAR-b leaderboard - this PR should fix it.