Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add GritLM-7B-noinstruct #28

Merged
merged 5 commits into from
Sep 11, 2024
Merged

re-add GritLM-7B-noinstruct #28

merged 5 commits into from
Sep 11, 2024

Conversation

Muennighoff
Copy link
Contributor

@Muennighoff Muennighoff commented Sep 10, 2024

It seems like the GritLM__GritLM-7B-noinstruct results present here https://github.com/embeddings-benchmark/results/tree/319e81d64298f3bdc5f09c8b6ff91f5015b3664c/results/GritLM-7B-noinstruct are no longer present here https://github.com/embeddings-benchmark/results/tree/9a79f7e07542ad2f5cb47490fa1e5ac2ba57d7a8/results; probably they were accidentally deleted so this PR adds them back in & also merges the separate GritLM folders; Currently the regular GritLM-7B is missing from the RAR-b leaderboard - this PR should fix it.

@Samoed
Copy link
Contributor

Samoed commented Sep 10, 2024

We've discussed why it was removed #25 (comment)

@Muennighoff
Copy link
Contributor Author

I see; I guess we should add it back in but maybe make sure model_meta is different then?

@Muennighoff Muennighoff mentioned this pull request Sep 10, 2024
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the name fix, I think we can add it in. Tests also still fail

@KennethEnevoldsen KennethEnevoldsen changed the title Standardize grit results re-add GritLM-7B-noinstruct Sep 11, 2024
Muennighoff and others added 3 commits September 11, 2024 08:10
@Muennighoff
Copy link
Contributor Author

Test is failing; I think it is because it is looking for where exists = PosixPath('/home/runner/work/results/results/results/GritLM__GritLM-7B/no_revision_available/model_meta.json').exists? Is the model_meta required even for no_revision_available folders? I think I can just move the results from that folder to the 13f00a0e36500c80ce12870ea513846a066004af folder as I doubt the model was different

@Samoed
Copy link
Contributor

Samoed commented Sep 11, 2024

I think that you can change fixture for test, because no_revision_available this is old result and GritLM versions are already presented here

folders_without_meta = [ # please do not add to this list it is only intended for backwards compatibility. Future results should have a model_meta.json file
or merge folders if results are the same or have different datasets

@Muennighoff
Copy link
Contributor Author

Makes sense, thanks!

It seems like there is some difference in FollowIR results e.g. https://github.com/embeddings-benchmark/results/blob/standardizegrit/results/GritLM__GritLM-7B/no_revision_available/Robust04InstructionRetrieval.json vs https://github.com/embeddings-benchmark/results/blob/standardizegrit/results/GritLM__GritLM-7B/13f00a0e36500c80ce12870ea513846a066004af/Robust04InstructionRetrieval.json & same for others. I think it is because I reran all MTEB tasks including them with GritLM.
Should we update to the results from rerunning (in the folder with a commit id) @orionw? It seems like the FollowIR scores are higher after rerunning for all three tasks; Is it because of a difference in prompting?

@orionw
Copy link
Contributor

orionw commented Sep 11, 2024

It could be, perhaps I did something wrong to the formatting. As long as the instructions were correctly passed in and it looks like it would be unless there was a prompt conflict then it should be fine.

I'm going to take a closer look at the instruction setup next week so I'm good with keeping the newer results!

@Muennighoff Muennighoff merged commit 1d30609 into main Sep 11, 2024
2 checks passed
@KennethEnevoldsen KennethEnevoldsen deleted the standardizegrit branch September 12, 2024 11:59
@Muennighoff Muennighoff mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants