Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: add warning for save_suffix removal from AbsTask #1940

Merged
merged 1 commit into from
Feb 3, 2025
Merged

misc: add warning for save_suffix removal from AbsTask #1940

merged 1 commit into from
Feb 3, 2025
+2 −0

Conversation

isaac-chung
Copy link
Collaborator

No version bump needed. Adding a warning for #1924

Code Quality

  • Code Formatted: Format the code using make lint to maintain consistent style.

Documentation

  • Updated Documentation: Add or update documentation to reflect the changes introduced in this PR.

Testing

  • New Tests Added: Write tests to cover new functionality. Validate with make test-with-coverage.
  • Tests Passed: Run tests locally using make test or make test-with-coverage to ensure no existing functionality is broken.

@isaac-chung isaac-chung changed the title add warning for param removal add warning for save_suffix removal from AbsTask Feb 3, 2025
@isaac-chung isaac-chung changed the title add warning for save_suffix removal from AbsTask misc: add warning for save_suffix removal from AbsTask Feb 3, 2025
This was referenced Feb 3, 2025
Open
Open
@Samoed Samoed merged commit 07c489d into main Feb 3, 2025
10 checks passed
@Samoed Samoed deleted the add-warn-for-removing-save_suffix branch February 3, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isaac-chung @Samoed