Merge pull request #2 from elvetemedve/fix/amend-process-factory-to-b…

…e-able-to-stop-processes Fix process create to use exec to be able to stop the processes
elvetemedve · Nov 16, 2015 · f4437bd · f4437bd
2 parents 27367ea + d1e4a54
commit f4437bd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/Services/ProcessFactory.php b/src/Services/ProcessFactory.php
@@ -51,7 +51,7 @@ public function createWebServerProcess($documentRoot, $hostname, $port)
         $documentRoot = escapeshellarg($documentRoot);
 
         return new Process(
-            sprintf('%s -S %s:%s -t %s', $this->phpBin, $hostname, $port, $documentRoot),
+            sprintf('exec %s -S %s:%s -t %s', $this->phpBin, $hostname, $port, $documentRoot),
             $documentRoot
         );
     }
@@ -65,7 +65,7 @@ public function createWebServerProcess($documentRoot, $hostname, $port)
     public function createBrowserProcess($browserCommand, $workingDirectory)
     {
         return new Process(
-            escapeshellcmd($browserCommand),
+            'exec ' . escapeshellcmd($browserCommand),
             $workingDirectory
         );
     }

diff --git a/src/TestRunnerContext.php b/src/TestRunnerContext.php
@@ -111,9 +111,9 @@ public function beforeRunTests()
      */
     public function afterRunTests(AfterScenarioScope $scope)
     {
-        $this->printTesterOutputOnFailure($scope);
         $this->clearWorkingDirectory();
         $this->destroyProcesses();
+        $this->printTesterOutputOnFailure($scope);
     }
 
     /**
@@ -150,7 +150,6 @@ public function destroyProcesses()
         }
 
         $this->processes = [];
-        $this->behatProcess = null;
     }
 
     /**