Allow initial elements as variadic into NewOrderedMap #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43
Adds a variadic argument to
NewOrderedMap
which allows the user to specify a set of initial data when initialising an ordered map. In my initial proposal I suggested a new function calledNewOrderedMapWithElements
. However, this isn't necessary to maintain backwards compatibility since the argument is variadic and still works when no arguments are set.I also considered a functional options style API which would allow for greater compatibility with any future changes:
However, this may be overkill for what is currently quite a simple API. It also loses the ability to initialise the underlying map with the correct size.
We could consider setting the size of the underlying list too, but I assume you are not doing this currently to save allocations. Maybe we only initialise if
len(els) > 0
?This change is