Skip to content

Commit

Permalink
Merge pull request #101 from elliot-100/minor
Browse files Browse the repository at this point in the history
Simplify dev/test deps, lint, doc fixes.
  • Loading branch information
elliot-100 authored Aug 9, 2024
2 parents 12bcea3 + 86a710e commit 3f420de
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 10 deletions.
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ and this project tries to adhere to [Semantic Versioning](https://semver.org/spe

Historic and pre-release versions aren't necessarily included.

## [0.10.0] - 20204-07-15

## [0.10.0] - 2024-07-15

### Changed

- *BREAKING CHANGES:*
- `get_profile_info()` returns`ProfileInfo` `NamedTuple` instead of dict
- `get_profile_info()` returns`ProfileInfo` `NamedTuple` instead of dict
- `get_manager_member_counts()` returns `ManagerMemberCounts` `NamedTuple`
instead of dict
- `club_manager_url_via_login()` renamed to `manager_url_via_login()`
Expand Down
8 changes: 7 additions & 1 deletion britishcycling_clubs/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def get_manager_member_counts(
Raises
------
`ValueError` :
ValueError :
if zero 'active members' would be returned, as it's assumed this indicates
an issue with data collection.
"""
Expand Down Expand Up @@ -103,6 +103,12 @@ def manager_url_via_login(club_id: str) -> str:
----------
club_id :
From the URL used to access club pages.
Returns
-------
str
URL
"""
return f"{_MANAGER_VIA_LOGIN_BASE_URL}{club_id}/"

Expand Down
7 changes: 6 additions & 1 deletion britishcycling_clubs/profile.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def get_profile_info(club_id: str) -> ProfileInfo:
Raises
------
`ValueError` :
ValueError :
if information can't be located.
"""
url = profile_url(club_id)
Expand All @@ -53,6 +53,11 @@ def profile_url(club_id: str) -> str:
----------
club_id :
From the URL used to access club pages.
Returns
-------
str
URL
"""
return f"{_PROFILE_BASE_URL}{club_id}/"

Expand Down
15 changes: 9 additions & 6 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ requests = ">=2.23.1"
playwright = ">=1.39.0"

[tool.poetry.group.dev.dependencies]
pdoc = "^14.5.0"
ruff = "^0.5.0"
pdoc = ">=14.6.0"
ruff = ">=0.5.7"

[tool.poetry.group.test.dependencies]
mypy = "^1.7.1"
pytest = "^7.4.2"
types-requests = "^2.31.0.10"
types-beautifulsoup4 = "^4.12.0.7"
mypy = ">=1.11.1"
pytest = ">=7.4.4"
types-requests = ">=2.32.0"
types-beautifulsoup4 = ">=4.12.0"

[tool.mypy]
strict = true
Expand All @@ -33,6 +33,9 @@ strict = true
module = "playwright"
disallow_untyped_calls = false

[tool.ruff]
target-version = "py38" # Ruff doesn't respect Python version in [tool.poetry.dependencies]

[tool.ruff.lint]
select = ["ALL"]

Expand Down

0 comments on commit 3f420de

Please sign in to comment.