Skip to content

Commit

Permalink
Don't depend on evision unless CONFIGURE_EVISION is set. Closes #13
Browse files Browse the repository at this point in the history
  • Loading branch information
kipcole9 committed Oct 4, 2022
1 parent 96afbb1 commit ef8cde5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## Image 0.10.0

This is the changelog for Image version 0.10.0 released on October 5th, 2022. For older changelogs please consult the release tag on [GitHub](https://github.com/kipcole9/image/tags)

### Bug Fixes

* Since the mix build process does a `File.cwd!/1` to the directory of each dependency we can't use the dirname of the dependency to decide whether to configure `:evision` or not. The strategy is now changed to configure `:evision` only if the environment `CONFIGURE_EVISION` is set. Note this is only relevant when developing `:image` itself. Consumers of the library should add `:evision` as a dependency manually in their application `mix.exs` as described in the `readme`. Thanks to @martosaur for the report. Closes #13.

## Image 0.9.0

This is the changelog for Image version 0.9.0 released on October 1st, 2022. For older changelogs please consult the release tag on [GitHub](https://github.com/kipcole9/image/tags)
Expand Down
7 changes: 3 additions & 4 deletions mix.exs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
defmodule Image.MixProject do
use Mix.Project

@version "0.10.0-rc.0"
@version "0.10.0"
@app_name "image"

def project do
Expand Down Expand Up @@ -136,10 +136,9 @@ defmodule Image.MixProject do

# Since hex packages can't have github deps in them
# we need a way to configure eVision only if we are
# developing the project. This method relies on the
# current directory being the project directory.
# developing the project.
defp dev? do
(Mix.env() != :release) && String.ends_with?(File.cwd!(), "/#{@app_name}")
(Mix.env() != :release) && System.get_env("CONFIGURE_EVISION")
end

defp otp_release do
Expand Down

0 comments on commit ef8cde5

Please sign in to comment.