Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies with warnings #723

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

TylerWitt
Copy link

I was digging around to ensure that JSON is supported, and saw a lot of deprecations when compiling deps.

I didn't bump decimal even though it also has warnings because I'm not sure if we want to bump to v2 only (now that Jason supports v2, which I'm assuming is why v1 was also supported), or if we want to keep testing the v1 version of the library for some reason.

I know it's a super minor change, though. Feel free to close!

Bumps db_connection to drop connection, since connection raises a bunch of deprecation warnings for Elixir 1.18
@josevalim
Copy link
Member

Thank you, although CI seems to be unhappy :)

@TylerWitt
Copy link
Author

Thank you, although CI seems to be unhappy :)

Yeah, I'm trying to check it out. I'm assuming it has to do with the db_connection changes.

@TylerWitt
Copy link
Author

The 1.17 branch seems to be an error that might have been fixed by Elixir 1.17.2

15:08:50.775 [error] Failure while translating Erlang's logger event\n** (MatchError) no match of right hand side value: 
%{callback_mode: :handle_event_function, client_info: :undefined, label: {:gen_statem, :terminate}, log: [], 
modules: [DBConnection.Connection], name: #PID<0.1902.0>, postponed: [], queue: [internal: {:connect, :init}], 
reason: {:error, %ArgumentError{message: \"expected :search_path to be a list of strings, got: \\\"public, extension\\\"\"}

@josevalim
Copy link
Member

Yes, let's bump v1.17 as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants