Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_for_null_in_comment #722

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

dkuku
Copy link
Contributor

@dkuku dkuku commented Dec 19, 2024

I'm not sure if it makes sense to precompile binary pattern for that?

@josevalim
Copy link
Member

It only makes sense to precompile if we can store it somewhere. That’s not the case here so we should be fine.

@josevalim josevalim merged commit c3097f4 into elixir-ecto:master Dec 19, 2024
8 of 9 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants