Blank screen#240 fix #241
Blank screen#240 fix #241
Conversation
| finish(); | ||
|
|
||
|
|
||
| runOnUiThread(new Runnable() { |
There was a problem hiding this comment.
While running application on local i faced an issue where after coming back to app it was running on different thread while loading data on to Screen. So i used runOnUiThread to in UI thread.
There was a problem hiding this comment.
While running application on local i faced an issue where after coming back to app it was running on different thread while loading data on to Screen. So i used runOnUiThread to in UI thread.
@arvind-1 Are you saying that the application was already downloading content from the REST API when you came back to the app after having opened it previously? If that's the case, maybe it would be better if we implement code that will cancel the download if the user leaves the activity (onStop()) before the download completes?
CC @gscdev
| @@ -65,13 +65,21 @@ protected void onStart() { | |||
| RoomDb.databaseWriteExecutor.execute(() -> { | |||
| List<Application> applications = applicationDao.loadAll(); | |||
| Log.d(getClass().getName(), "applications.size(): " + applications.size()); | |||
| applicationListAdapter.setApplications(applications); | |||
|
|
|||
| if(null!=applications) { | |||
There was a problem hiding this comment.
Change to if (applications != null) {
app/src/main/java/ai/elimu/appstore/ui/applications/ApplicationListActivity.java
Show resolved
Hide resolved
app/src/main/java/ai/elimu/appstore/ui/applications/ApplicationListActivity.java
Show resolved
Hide resolved
| if(applications != null) { | ||
| applicationListAdapter.setApplications(applications); | ||
| } |
There was a problem hiding this comment.
| if(applications != null) { | |
| applicationListAdapter.setApplications(applications); | |
| } |
This code change is not necessary, right? (Since applicationListAdapter.notifyDataSetChanged(); is the line causing the error.)
| List<ApplicationVersion> applicationVersions = applicationVersionDao.loadAll(); | ||
| Log.d(getClass().getName(), "applicationVersions.size(): " + applicationVersions.size()); | ||
| applicationListAdapter.setApplicationVersions(applicationVersions); | ||
|
|
||
| applicationListAdapter.notifyDataSetChanged(); | ||
|
|
||
| recyclerView.post(new Runnable() { |
There was a problem hiding this comment.
To avoid the dependence on recyclerView, use runOnUiThread instead?:
| recyclerView.post(new Runnable() { | |
| runOnUiThread(new Runnable() { |
| applicationListAdapter.notifyDataSetChanged(); | ||
| } | ||
| }); | ||
|
|
No description provided.