Skip to content

Commit

Permalink
Update to the most recent changes in api-sdk
Browse files Browse the repository at this point in the history
  • Loading branch information
giorgiosironi committed Jan 9, 2025
1 parent 64a3f21 commit af95445
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
10 changes: 5 additions & 5 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions test/ViewModel/Converter/TeaserTermsBuilderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ final class TeaserTermsBuilderTest extends TestCase
*/
private $builder;

private $elifeAssessmentTitle = 'Lorem ipsum';

/**
* @before
*/
Expand All @@ -28,7 +30,7 @@ public function setUpConverter()
*/
final public function it_builds_significance_terms_when_there_are_significance_terms_and_no_strength_terms_are_available()
{
$elifeAssessment = new ElifeAssessment(['landmark'], null);
$elifeAssessment = new ElifeAssessment($this->elifeAssessmentTitle, ['landmark'], null);
$result = $this->builder->build($elifeAssessment);

$expected = new TeaserTerms([new Term('Landmark')]);
Expand All @@ -40,7 +42,7 @@ final public function it_builds_significance_terms_when_there_are_significance_t
*/
final public function it_does_not_build_significance_terms_when_there_are_none_in_the_assessment_and_no_strength_terms_are_available()
{
$elifeAssessment = new ElifeAssessment([], null);
$elifeAssessment = new ElifeAssessment($this->elifeAssessmentTitle, [], null);
$result = $this->builder->build($elifeAssessment);

$this->assertNull($result);
Expand All @@ -51,7 +53,7 @@ final public function it_does_not_build_significance_terms_when_there_are_none_i
*/
final public function it_builds_strength_terms_when_there_are_strength_terms_and_no_significance_terms_are_available()
{
$elifeAssessment = new ElifeAssessment(null, ['convincing']);
$elifeAssessment = new ElifeAssessment($this->elifeAssessmentTitle, null, ['convincing']);
$result = $this->builder->build($elifeAssessment);

$expected = new TeaserTerms([new Term('Convincing')]);
Expand All @@ -63,7 +65,7 @@ final public function it_builds_strength_terms_when_there_are_strength_terms_and
*/
final public function it_builds_terms_using_both_significance_and_strength_terms_in_that_order()
{
$elifeAssessment = new ElifeAssessment(['landmark'], ['solid']);
$elifeAssessment = new ElifeAssessment($this->elifeAssessmentTitle, ['landmark'], ['solid']);
$result = $this->builder->build($elifeAssessment);

$expected = new TeaserTerms([new Term('Landmark'), new Term('Solid')]);
Expand Down

0 comments on commit af95445

Please sign in to comment.