Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @pub-type attributes from XML (depreciated tag in JATS) #83

Open
2 tasks
Melissa37 opened this issue Nov 27, 2018 · 4 comments
Open
2 tasks

Remove @pub-type attributes from XML (depreciated tag in JATS) #83

Melissa37 opened this issue Nov 27, 2018 · 4 comments

Comments

@Melissa37
Copy link

Problem / Motivation

  • WHO; Production
  • WHEN: When all other updates are made
  • WHERE: In the XML
  • WHAT: change @pub-type to @date-type in the XML pub-date pub-type="collection"> to pub-date date-type="collection">
  • WHY: @pub-type is depreciated in favour of @date-type and @publication-format. This will also match Texture requirements.

Proposed solution

change @pub-type to @date-type in the XML pub-date pub-type="collection"> to pub-date date-type="collection">

Clarification needed and assumptions


Tasks

  • Check in PMC style checker
  • Check does not affect any Bot processes

Technical notes

@gnott

User interface / Wireframes

@gnott
Copy link
Member

gnott commented Nov 27, 2018

In the JATS parser we can support both, I'm tempted to do that now so it doesn't creep up on us.

We still use the "collection" date to determine from the XML alone whether it is a PoA or non-PoA article version in some places, the PubMed delivery logic I think.

@Melissa37
Copy link
Author

That's good.
Thanks!

@gnott
Copy link
Member

gnott commented Mar 11, 2019

Is this completed now @Melissa37 ?

@Melissa37
Copy link
Author

No, it's on the long list for Texture implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants