refactor: default to noImplicitOverride #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding methods in TypeScript is easy... too easy. This pull request adds the
override
keyword, and defaults tonoImplicitOverride
. This protects us from future changes that might go unnoticed, for example:Before - no
override
keyword, andnoImplicitOverride
set tofalse
.@elgato/streamdeck
renamesonWillDisappear
toonDisappear
.onDisappear
event as the method is overridingonWillDisappear
.After -
override
keyword andnoImplicitOverride
set totrue
.@elgato/streamdeck
renamesonWillDisappear
toonDisappear
.onWillDisappear
to beonDisappear
as part of the upgrade, and everything works.