Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Redesign #281

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Updates Redesign #281

merged 4 commits into from
Jan 22, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 22, 2024

Makes updates a feature of the operating system view instead of a whole separate view. Some things to maybe improve:

  • Have a "show details" button that opens a dialog with a list of all the individual packages
  • I'd rather use the update file size than number of packages but it's returning 0?
  • Error handling

Screenshot from 2024-01-22 14 15 06

@danirabbit danirabbit force-pushed the danirabbit/system-updates branch from 28891eb to 7005ca5 Compare January 22, 2024 22:25
@danirabbit danirabbit mentioned this pull request Jan 22, 2024
@leolost2605
Copy link
Member

First of all this looks really amazing!

I'd rather use the update file size than number of packages but it's returning 0?

Yeah that's what I was going for but I don't know how to get it yet so that's why it's marked as todo in the settings daemon PR

Error handling

So my current flow is that if an error occurs the settings daemon sends a notification that if clicked on spawns a message dialog whith details. Meanwhile the daemon also forces a cache refresh deleting all downloaded updates so that in the settings only the updates list gets shown again. So the settings wouldn't know about any error that happened. But maybe we want more something like
Error happened -> notification -> settings show error with info for details and refresh button

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at the code very much but since it's WIP anyways let's goo, it really looks amazing lol 😍

@danirabbit danirabbit merged commit ce2f0b5 into system-updates Jan 22, 2024
3 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/system-updates branch January 22, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants