Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Gtk4 #249

Merged
merged 24 commits into from
Dec 24, 2023
Merged

Port to Gtk4 #249

merged 24 commits into from
Dec 24, 2023

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented May 30, 2022 •
edited
Loading

No description provided.

@danirabbit danirabbit changed the title Begin porting to Gtk4 Port to Gtk4 Dec 21, 2023
@danirabbit danirabbit requested a review from a team December 21, 2023 19:51
@danirabbit danirabbit marked this pull request as ready for review December 21, 2023 19:51
@danirabbit danirabbit mentioned this pull request Dec 21, 2023
Merged
jeremypw
jeremypw reviewed Dec 23, 2023
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and everything seems to work as expected. It is found as expected by typing keywords into Applications Menu.

Not sure of the significance of the failed CI though. Should this be merged into a main branch?

@danirabbit
Copy link
Member Author

@jeremypw stable is failing because it doesn't have switchboard-3. I'll remove the merge requirement since this is only intended to be shipped for OS 8 :)

When we merge I'll rename master to main and update LP recipes etc

@danirabbit danirabbit merged commit a87e106 into master Dec 24, 2023
3 of 4 checks passed
@danirabbit danirabbit deleted the gtk4 branch December 24, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GTK4 Porting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw