Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractInstallerView: handle more layout #150

Merged
merged 4 commits into from
Nov 18, 2022
Merged

AbstractInstallerView: handle more layout #150

merged 4 commits into from
Nov 18, 2022

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Nov 17, 2022 •
edited
Loading

  • Have this view handle more of the side-by-side layout by adding a title_area
  • Replace ButtonBox in preparation for Gtk4. We have to set width_requests manually here to preserve the minimum button width that was previously built into `ButtonBox. See Granite.ButtonBox? granite#577

@danirabbit danirabbit requested a review from a team November 17, 2022 17:36
meisenzahl
meisenzahl approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@meisenzahl meisenzahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

+1 for elementary/granite#577 or at least a constant in granite for the width_request.

@danirabbit danirabbit merged commit 472d671 into master Nov 18, 2022
@danirabbit danirabbit deleted the abstractlayout branch November 18, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisenzahl meisenzahl meisenzahl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @meisenzahl