Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WorkspaceManager: avoid using Meta.WorkspaceManager.list_workspaces #2243

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

WorkspaceManager: avoid using Meta.WorkspaceManager.list_workspaces #2243

wants to merge 6 commits into from

Conversation

lenemter
Copy link
Member

I'm not sure if this is a true cause of the crashes but #2242, #2227, #2232 indicate that the issue is somewhere here

@lenemter lenemter requested a review from a team January 25, 2025 13:47
leolost2605
leolost2605 requested changes Jan 26, 2025
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments adjusting for the fact that we remove workspaces in the for loop which might lead to some out of bounds/skipping workspaces issues.

src/WorkspaceManager.vala Show resolved Hide resolved
src/WorkspaceManager.vala Outdated Show resolved Hide resolved
src/WorkspaceManager.vala Outdated Show resolved Hide resolved
@lenemter lenemter requested a review from leolost2605 January 26, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leolost2605 leolost2605 Awaiting requested review from leolost2605

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lenemter @leolost2605