Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultitaskingView: Add blurred wallpaper #1810

Merged
merged 13 commits into from
Jan 29, 2024
Merged

Conversation

lenemter
Copy link
Member

Fixes #1796

@danirabbit
Copy link
Member

danirabbit commented Dec 18, 2023

Very cool! Is there a reason we didn't use the Clutter blur effect and implemented our own?

I submitted a branch here to add a brightness effect for some extra contrast, thoughts? #1811

I'm getting a consistent crash on logging into the session and entering the multitasking view. If I switch workspaces first it doesn't crash

@lenemter
Copy link
Member Author

Very cool! Is there a reason we didn't use the Clutter blur effect and implemented our own?

I think it uses a simple shader with a small blur radius and there's no way to change it.

I'm getting a consistent crash on logging into the session and entering the multitasking view. If I switch workspaces first it doesn't crash

Can you provide the backtrace please? It doesn't crash on my side.

@lenemter
Copy link
Member Author

@danirabbit I actually found a typo I made that made it crash with certain blur radius. I hope it fixes the crash for you too

@lenemter lenemter requested a review from a team January 29, 2024 10:42
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

@danirabbit danirabbit merged commit 156e415 into master Jan 29, 2024
4 checks passed
@danirabbit danirabbit deleted the lenemter/blur-effect branch January 29, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Blur wallpaper behind multitasking view
2 participants