Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animate nudge with clones #1803

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Animate nudge with clones #1803

merged 7 commits into from
Dec 12, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Nov 18, 2023 •
edited
Loading

Fixes #1799
Fixes #1287
Fixes #927

Reuses clones used for workspace switch animation.

@lenemter lenemter requested review from a team and removed request for a team November 18, 2023 11:03
@lenemter lenemter marked this pull request as ready for review November 18, 2023 11:22
@lenemter lenemter requested a review from a team November 18, 2023 11:22
@lenemter lenemter changed the title Animate nudge animation with clones Animate nudge with clones Nov 18, 2023
Marukesu
Marukesu approved these changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@Marukesu Marukesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the behaviour with the last gap, i don't have a extra monitor so i can't confirm about the behaviour on it.

@lenemter

This comment was marked as resolved.

Sign in to view
@lenemter
Copy link
Member Author

Double checked if this PR fixes #927, and it does. So I'm gonna merge this.

@lenemter lenemter merged commit 51d270e into master Dec 12, 2023
4 checks passed
@lenemter lenemter deleted the lenemter/improve-nudge-animation branch December 12, 2023 09:22
@lenemter lenemter mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marukesu Marukesu Marukesu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OS 8
Status: Done
Milestone
No milestone
2 participants
@lenemter @Marukesu