Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Move to workspace" gesture #1780

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Add "Move to workspace" gesture #1780

merged 4 commits into from
Oct 26, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Oct 26, 2023 •
edited
Loading

Closes #1739
Fixes #1109

@lenemter lenemter requested a review from a team October 26, 2023 02:56
lenemter
lenemter commented Oct 26, 2023
View reviewed changes
src/WindowManager.vala Outdated Show resolved Hide resolved
danirabbit
danirabbit approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect! Feels super good, love it. Nice code cleanup too, makes the logic way clearer here

@danirabbit danirabbit merged commit 493dd89 into master Oct 26, 2023
@danirabbit danirabbit deleted the move-to-workspace-gesture branch October 26, 2023 18:03
@danirabbit danirabbit mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OS 8
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for transform current focused app to other/new workspace Use gestures for "move to workspace"
2 participants
@lenemter @danirabbit