ShellClients: Don't make centered clients docks but allow their short…

…cut inhibition without dialog (#1995)

data/io.elementary.desktop.wm.shell

@@ -2,10 +2,6 @@
 launch-on-x=true
 args=io.elementary.wingpanel
 
-[io.elementary.desktop.agent-polkit]
-launch-on-x=true
-args=/usr/libexec/policykit-1-pantheon/io.elementary.desktop.agent-polkit
-
 [io.elementary.dock]
 launch-on-x=true
 args=io.elementary.dock

src/Dialogs.vala

@@ -229,8 +229,9 @@ namespace Gala {
                 return;
             }
 
-            // Naive check to always allow inhibiting by our settings app. This is needed for setting custom shortcuts
-            if (app.id == "io.elementary.settings.desktop") {
+            if (app.id == "io.elementary.settings.desktop" || // Naive check to always allow inhibiting by our settings app. This is needed for setting custom shortcuts
+                ShellClientsManager.get_instance ().is_positioned_window (window) // Certain windows (e.g. centered ones) may want to disable move via super + drag
+            ) {
                 on_response (0);
                 return;
             }

src/ShellClients/ShellClientsManager.vala

@@ -186,11 +186,22 @@ public class Gala.ShellClientsManager : Object {
             return;
         }
 
-        make_dock (window);
-
         centered_windows[window] = new CenteredWindow (wm, window);
     }
 
+    public bool is_positioned_window (Meta.Window window) {
+        bool positioned = (window in centered_windows) || (window in windows);
+        window.foreach_ancestor ((ancestor) => {
+            if (ancestor in centered_windows || ancestor in windows) {
+                positioned = true;
+            }
+
+            return !positioned;
+        });
+
+        return positioned;
+    }
+
     //X11 only
     private void parse_mutter_hints (Meta.Window window) requires (!Meta.Util.is_wayland_compositor ()) {
         if (window.mutter_hints == null) {

src/WindowStateSaver.vala

@@ -66,6 +66,10 @@ public class Gala.WindowStateSaver : GLib.Object {
             return;
         }
 
+        if (ShellClientsManager.get_instance ().is_positioned_window (window)) {
+            return;
+        }
+
         if (!(app_id in app_windows)) {
             app_windows[app_id] = new GLib.Array<Meta.Window?> ();
         }