Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user selected version #300

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

huangmingfu
Copy link
Contributor

  • 修复用户选择的版本,分享之后打开链接不能默认选中的问题。
    复现地址 ,选择版本号之后,点击分享按钮,不能正常携带用户选择的版本号。
    image

Copy link

vercel bot commented Jan 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
element-plus-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 1:28am

Copy link
Contributor

@Dsaquel Dsaquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like some code is not formatted, can you pnpm format ?

src/composables/store.ts Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
fix: cannot be persistent between reload

Co-authored-by: Noblet Ouways <[email protected]>
@Dsaquel
Copy link
Contributor

Dsaquel commented Jan 21, 2025

LGTM, thanks !

cc @btea

src/composables/store.ts Outdated Show resolved Hide resolved
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@btea btea merged commit dba6a4b into element-plus:main Feb 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants