This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Restore missing metrics & remove unused ones #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use Signal UUIDs as keys instead strings
Decrement a user's connection/login count only if a count for that user has been created.
instead of only when logged out
Mimic the naming scheme of mautrix-whatsapp metrics
as this metric is less useful now that the Signal event handler doesn't directly monitor/return errors anymore
Half-Shot
approved these changes
Feb 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges in mautrix#463 to work with the changes to logout handling added by mautrix#439, which is not in upstream.
It also removes a metric that was exclusive to the Element fork, the usage of which was lost since an upstream refactoring to Signal message handling (mautrix@9efe31d) and doesn't seem to be important enough to warrant being restored.