This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Hs/hotfix missing profile key #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
changed the base branch from
element-main
to
tadzik/user-activity-query
Half-Shot
changed the base branch from
tadzik/user-activity-query
to
element-main
AndrewFerr
reviewed
Feb 21, 2024
Comment on lines
+270
to
+272
| if encryptedAvatar == nil { | ||
| return nil, fmt.Errorf("failed to read response body: encryptedAvatar was nil") | ||
| } |
There was a problem hiding this comment.
This one shouldn't be needed since decryptBytes will exit if the length of encryptedAvatar is too short, and the length of a nil slice is 0.
Comment on lines
+344
to
+348
| if info.ProfileKey != nil { | ||
| log.Err(err). | ||
| Msg("Failed to download new user avatar, no profile key for contact") | ||
| return true | ||
| } |
There was a problem hiding this comment.
Now that the key is checked for nil in DownloadUserAvatar, this can be removed.
|
Believe superseded by #24 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough fix to the problem I was seeing where we were attempting to download contact info for a contact that lacks a profile key. I'm pretty sure we should fail earlier, but this prevents it from crashing.