Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update verify identity button title. #3466

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Update verify identity button title. #3466

merged 2 commits into from
Oct 30, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave requested a review from a team as a code owner October 30, 2024 08:56
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 30, 2024 08:56
@pixlwave pixlwave added pr-change for updates to an existing feature pr-misc for other changes and removed pr-change for updates to an existing feature labels Oct 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against c49ac47

manuroe
manuroe approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pixlwave!

LGTM.
It makes me wonder: how do we manage orphan strings? L10n.screenRoomMemberDetailsVerifyButtonTitle() is not going to be used anymore and it is dead code.

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
848 1 847 0
View the full list of 1 ❄️ flaky tests 
RoomScreenViewModelTests testPinnedEventsBanner()

Flake rate in main: 26.06% (Passed 122 times, Failed 43 times)

Stack Traces | 11.9s run time 
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave
Copy link
Member Author

how do we manage orphan strings?

We don't have anything more formal than every once in a while (I think we've done it once) we can run Periphery to find unused strings, Android run something similar on their side and then we compare notes and agree what can be removed.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pixlwave pixlwave merged commit 6f15826 into develop Oct 30, 2024
7 checks passed
@pixlwave pixlwave deleted the doug/verify-identity branch October 30, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuroe manuroe manuroe approved these changes

@Velin92 Velin92 Awaiting requested review from Velin92 Velin92 is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
pr-misc for other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @manuroe