Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Compound. #2906

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Update Compound. #2906

merged 3 commits into from
Jun 7, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jun 6, 2024

This PR makes the following changes:

  • Update Compound to the latest revision (the snapshots are no longer in Git LFS, see #84).
  • Update Introspect and Prefire packages to match Compound (it would be nice if we could remove these from project.yml seeing as they're pulled in by Compound but I got an error about trying to add them in target.yml).
  • Use the new markAsRead/Unread icons when long-pressing a room.

@pixlwave pixlwave requested a review from a team as a code owner June 6, 2024 15:20
@pixlwave pixlwave requested review from Velin92 and removed request for a team June 6, 2024 15:20
Copy link

github-actions bot commented Jun 6, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 5f0b633

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 👍

@@ -7287,7 +7287,7 @@
repositoryURL = "https://github.com/BarredEwe/Prefire";
requirement = {
kind = upToNextMinorVersion;
minimumVersion = 2.0.4;
minimumVersion = 2.7.0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this change breaks the preview tests -> Switch to using iPhone15,2 for these tests.
I'll just change the required version to iPhone15 to avoid this in the future

Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefanceriu stefanceriu enabled auto-merge (squash) June 7, 2024 07:14
@stefanceriu stefanceriu disabled auto-merge June 7, 2024 09:25
@stefanceriu stefanceriu merged commit 8a52ed0 into develop Jun 7, 2024
4 of 5 checks passed
@stefanceriu stefanceriu deleted the doug/compound branch June 7, 2024 09:25
stefanceriu added a commit that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants