Initial implementation of the JoinRoomScreen. #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 080d050 |
pixlwave
force-pushed
the
doug/join-room-screen
branch
from
619c3e8
to
fef3c68
Compare
pixlwave
force-pushed
the
doug/join-room-screen
branch
from
fef3c68
to
007155f
Compare
pixlwave
force-pushed
the
doug/join-room-screen
branch
from
007155f
to
080d050
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires element-hq/compound-ios#67
This PR includes an initial implementation of the screen to join a room from a permalink.
Note: The contents of the screen may change depending on what the SDK API gives us to align closer to the one from the room discovery flow as we'll likely share the screen, but for now I'm matching what is in Figma.